Skip to content

Simplify kNN #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Simplify kNN #3

wants to merge 9 commits into from

Conversation

Cugtyt
Copy link
Contributor

@Cugtyt Cugtyt commented Nov 14, 2017

  1. Broadcasting is better than tile, Counter is better than count by iteration, list comprehension is better than simple for.
  2. [index, :] == [index] in numpy
  3. dict is better than if if if.
  4. Result of divide is always float.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Cugtyt